I would’ve uses regexes in the lexee instead of range comparisons for characters, and would’ve avoided if statements, but that is just my own taste. Cool project!
I actually used the credo analyzer on the source code. I did not change everything according to its suggestions, but one of them was that you should actually use if over cond if there are not at least two none-default branches in the cond statement.
That’s really neat!
I would’ve uses regexes in the lexee instead of range comparisons for characters, and would’ve avoided
ifstatements, but that is just my own taste. Cool project!Interesting about
ifstatements, do you usecondby default then? I certainly don’t stick to one conditional style in the Elixir I write.This might be a little weird, but I tend to just stick with
caseunless I have a compelling reason to do otherwise.I actually used the credo analyzer on the source code. I did not change everything according to its suggestions, but one of them was that you should actually use
ifovercondif there are not at least two none-default branches in thecondstatement.Thank you! Very good points! :)