1. 37
  1. 12

    This was almost 10 months in the making, with 2 attempts and coming back from the PR being closed by Stalebot multiple times. So glad it’s finally done.

    1. 13

      I hate stale bots so much. They generate way too much noise and make it hard to work on larger, longer features.

      1. 3

        Exactly. Make use of sorting/filters/labels instead.

        1. 3

          One more argument for leaving GitHub! I haven’t seen stale bots on any of the FOSS code forges yet, and maybe we can build a culture that has better ways of dealing with the (entirely valid) problems of overwhelmed and demotivated maintainers.

          1. 1

            They are a necessary evil, especially for a project like Serenity. People love to invent, or port a feature or some grand refactoring, and then they get tired of it and leave their work to rot forever. The serenity stale bot as closed ~500 PRs over it’s life time that were left with no activity for over a month.

            1. 3

              In my opinion, pull requests that are not ready for review (i.e. drafts or failing CI checks), are fair game to be closed as stale. However, bug reports, feature requests, and PRs that pass CI checks should remain open until they get attention from a maintainer.

              1. 3

                I totally agree with that. We explicitly don’t enable stale bot for any issues, only PRs. There have been cases where PRs slipped through the cracks in SerenityOS and stale bot happened to close them. It’s just one click to bring them back and get them merged, so it always seemed like a reasonable trade-off to me. The community is generally watching for what stale bot reaps and have been good about raising anything that should be given attention.

                1. 1

                  Then you have a good community and I’m glad that it works for you. A wasteland of open-but-stale stuff is no fun to wade through.

        2. 10

          Corresponding blog post (I didn’t make the connection until Andreas pointed it out just now) is https://sin-ack.github.io/posts/sycl-talk-20221007/.

          1. 5

            Here is the Lobsters discussion for that post