Good overview đ Although I think the part about the TimeoutHandler() etc. is a bit redundant now that we have context? As far as I know, it can replace all use cases?
One thing that might be worth mentioning is that you usually shouldnât pass the same context to a goroutine. For example:
func handle(w ResponseWriter, r *Request) {
ctx, cancel := WithTimeout(r.Context())
defer cancel()
// ...
go sendmail(r.Context(), ...)
// ...
}
This usually works most of the time on the dev environment since the mock email is probably fast, but on production it might take a second or two (hence the goroutine) and it will be cancelled before it finishes.
This is especially subtle if you add a timeout on the request context in the middleware, so youâre used to using r.Context().
Youâll need to use a new context.Background() (or create a new one with the appropriate values, if you use contexts like that).
Just something Iâve seen several people do wrong over the years (and have done wrong myself once or twice as well đ ).
I like your example with r.Context and a goroutine. Another gotcha in this situation is that deferred cancel func will be called on handler function exit. So using timeout + cancel + goroutine is not obvious for newcomers.
Good overview đ Although I think the part about the
TimeoutHandler()etc. is a bit redundant now that we have context? As far as I know, it can replace all use cases?One thing that might be worth mentioning is that you usually shouldnât pass the same context to a goroutine. For example:
This usually works most of the time on the dev environment since the mock email is probably fast, but on production it might take a second or two (hence the goroutine) and it will be cancelled before it finishes.
This is especially subtle if you add a timeout on the request context in the middleware, so youâre used to using
r.Context().Youâll need to use a new
context.Background()(or create a new one with the appropriate values, if you use contexts like that).Just something Iâve seen several people do wrong over the years (and have done wrong myself once or twice as well đ ).
[Comment removed by author]
I like your example with r.Context and a goroutine. Another gotcha in this situation is that deferred cancel func will be called on handler function exit. So using timeout + cancel + goroutine is not obvious for newcomers.
https://play.golang.org/p/X3_ry5WXYKY
[Comment removed by moderator alynpost: remove accidental, duplicate comment.]