I put those (reportedly useless) quotes in there for 1 reason myself: consistency. If I happen to need to quote one of the values because it contains a space, why aren’t all other values of the same nature quoted too?
If all computer languages I know of use quotes to delimit the beginning and ending of string values, why should the space implicitly mark the ending of a string?
Somewhat related: I use “useless” quotes in YAML too, for the same reason, why should the newline character mark the ending of a string when we’ve had quotes for decades?
Right. Why should the newline character mark the ending of a statement when we’ve had parentheses for more than half a century?
Rants are usually bad opinions expressed angrily, to give them a veneer of seriousness / quality they wouldn’t otherwise have. Affective override is a powerful thing.
I can also see problems happening when an unquoted property is later replaced by a variable. If the variable contains spaces, there’s suddenly a problem. Of course, whoever added the variable should have checked that, but having quotes everywhere makes things more consistent and safer, and avoid having to think all the time whether there should be quotes here or not.
Sure, in a shell language I assume you mean. Defensive programming is a mindset not everyone adopts, and the choices here would be suboptimal as defensive choices. You’re right in identifying another case of this.
I wonder if the author also knows all the C precedence rules and yells if anyone uses unnecessary parenthesis.