1. 21
  1.  

  2. 9

    You can form your own opinion here: https://github.com/xtermjs/xtermjs.org/pull/54

    Contributors feeling entitled to have their patches merged is indeed an recurring Problem in OSS.

    1. 10

      This replier (not sure if he is a maintainer or not) approaches this issue perfectly, IMO. He is patient and calmly explains the reasons why projects won’t merge PR’s simply because they exist and pass all checks/tests. The person making the PR really comes off as entitled, and seems to conflate saying “no, we won’t merge this PR” with impoliteness.

      Thanks for linking, it helps with the context of this post.

    2. 5

      Saying no really is just part of the development process, I’m surprised that contributors would be angry about that. From my experience, most free software projects are reasonably welcoming. The problems with onboarding new contributors usually are:

      • PRs getting no reaction for a long time. People think their code isn’t needed or wanted. I think it’s good to even do a quick comment like “I don’t have time to review this right now” or “I think this part needs reworking”), at least it makes the other person know that they are not being ignored.
      • People not being brave enough to actually do a PR. I’ve seen people post so much about things like “I got it to work, but the code is so ugly, I’ll never do a PR”. I’ve had to bug people for weeks to get them to make an PR, and it was pretty much perfect code, but they still were nearly too nervous to do it.
      • Replies with rework requests but without any pointers on how to do it. If a beginner doesn’t know the structure of a program, even just telling them in which files they should look for something can be a big help.
      1. 3

        I don’t know why “NO” was capitalised there. I mean, that’s not exactly welcoming in itself.

        Also:

        Apparently, even after a maintainer’s NO, there can be space for further conversation and clarification

        “Apparently”? I’m really not getting a welcoming vibe.

        1. 1

          I’m late to the party but this reminds me of Isaac Schlueter on “No”, which “stands for Node Optimized and is also gonna be what [he] says any time someone asks for a feature.”