sometimes syscalls restart | Lobsters

8

sometimes syscalls restart c openbsd programming tedunangst.com
via merzberimbow 2 years ago | cached | 5 comments

5

3
alynpost edited 2 years ago | link
If anyone would like see the patch, I had trouble getting to it from the blog.

I don’t understand the loop condition in the patch:
```
    case SIGCHLD:
-       while (waitpid(WAIT_ANY, 0, WNOHANG) > 0) {}
+       do {
+           pid = waitpid(WAIT_ANY, NULL, WNOHANG);
+       } while(pid != -1 || (pid != -1 && errno == EINTR));
        break;
```
The (pid != -1 && errno == EINTR) condition seems entirely redundant; shouldn’t it be (pid == -1 && errno == EINTR)? @tedu would you mind checking my work here?
1. 2
  
  tedu 2 years ago | link
  
  Yeah, looks like a typo.
  1. 1
    
    alynpost 2 years ago | link
    
    Thank you. If you could let reyk know, I’d appreciate it. I’d be happy if you wanted to make an introduction instead, but that seems overblown for a typo.
    1. 2
      
      tedu 2 years ago | link
      
      Already fixed! Thanks. (And sorry, I forgot to mention you in the commit.)
      1. 2
        
        alynpost 2 years ago | link
        
        No worries, we can save that for a change involving more than one character. You’re fast!