1. 3

    When you’re doing a pull request, some random guru-senior-architect might occasionally check your code and suggest few changes. Sounds unlikely but any additional eyes might uncover bugs or architecture mistakes.

    Is this true? I would love to have someone review my code but I cant see it ever happening. Do I just open a PR and hope someone comes along to review it? How would they even know I am waiting for public review. It feels quite rude to jump in to someone elses project and start reviewing their changes.

    1. 4

      “Watchers” of the repo will get notifications, so they can get involved pretty easily if they want to. Also, you can add a label like “needs review” or something like that to attract more attention.

    1. 2

      The range check comments are reversed I think.

      1. 1

        Oh, that’s right. Thank you! I think the issue is in the README only though. Warnings are given in a proper format.

      1. 1

        Note that there is also RU version available, in case you’re more comfortable with it: https://habr.com/post/416903/ It also includes a bonus gopher image. :3